generated from mgramigna/typescript-node-starter
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data requirements comparison script #295
Merged
Merged
+512
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success451 tests passing in 31 suites. Report generated by 🧪jest coverage report action from 5ea2981 |
lmd59
reviewed
Mar 8, 2024
lmd59
reviewed
Mar 10, 2024
hossenlopp
reviewed
Mar 19, 2024
elsaperelli
force-pushed
the
dr-comparison-script
branch
from
March 20, 2024 17:00
9f73733
to
6ad518d
Compare
hossenlopp
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.gitkeep
files get removed by runs, this could result in them accidentally being removed in a commit.
elsaperelli
force-pushed
the
dr-comparison-script
branch
from
March 21, 2024 16:06
f610b53
to
5ea2981
Compare
hossenlopp
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we are reworking our data requirements calculation in fqm-execution, we have found a need for comparing our data requirements output to that of the elm-parser-for-ecqms, which we know to be a more accurate data requirements calculation.
New behavior
No need behavior within fqm-execution, just the addition of scripts for comparison and the
/data-requirements
directory that contains everything (structured similarly to the/regression
directory).Code changes
data-requirements/README.md
- explains the purpose of the data-requirements directory and scripts and details instructions on how to run the scripts and how to interpret their outputs.data-requirements/compare.sh
- this script compares the overall outputs of the data requirements (similar to the regression script).gitignore
- add some directories from/data-requirements
.gitkeep
- addjan-2024-connectathon
to keep an empty directorydata-requirements/fqm-e-dr.ts
- helper file for calculating the data-requirements for all measures in jan-2024-connectathon using fqm-execution (used in both bash scripts)data-requirements/summary-compare.sh
- summary comparison bash scriptdata-requirements/summary-compare.ts
- summary comparison helper fileTesting guidance
NOTE: I detail most of the necessary information in the
/data-requirements/README.md
so please let me know if there is anything missing in that file that would be helpful!README.md
for running instructions and output descriptions.